Sheffield | ITP-May-2025 | Waleed-Yahya Salih-Taha | Sprint-3 | Quote-generator #731
Conversation
Bluejay600
added
📅 Sprint 3
day-lee
added
Review in progress
Sprint-3/quote-generator/index.html
Outdated
| <title>Quote Generator App</title> | ||
|
|
||
| <!-- Optional: Link to CSS if styling is needed --> | ||
| <link rel="stylesheet" href="styles.css" /> |
There was a problem hiding this comment.
It seems you added styles to your app but it doesn't show on the page. Can you figure out why?
There was a problem hiding this comment.
I'm trying to find out why the style code is not active on the website, but since adding style is not mandatory I thought uploading the PR will fastened my code reviewing.
There was a problem hiding this comment.
It wasn't working because you added an 's' to the href. href="styles.css" should match the filename in your commit, which is '../style.css'. It happens 😂
There was a problem hiding this comment.
oooh my God. it's really my bad.
thank you for your help.
Sprint-3/quote-generator/index.html
Outdated
| <p id="author"></p> | ||
| </section> | ||
|
|
||
| <button type="button" id="new-quote" aria-label="Get a new quote"> |
There was a problem hiding this comment.
It's great that you considered accessibility and added aira-label. But when there is a visible text in the button, New quote, it might be unnecessary to add more description as screen reader might say it two times.
|
Superb! Code looks good. I left a few comments. Please have a look. |
day-lee
added
Reviewed
Bluejay600
added
Needs Review
day-lee
added
Complete
|
Good job! |
Learners, PR Template
Self checklist
Changelist
This PRs finds the basic setup of a quote generator, When the page loads it should show a random quote from the
quotesarray on the screen. It should also show who said the quote.Questions
Ask any questions you have for your reviewer.